PathColumn : Allow sorting of FileIconPathColumn #6012
Conversation
There was a problem hiding this comment.
I think this is fine (pending Eric's input on the Windows side), but I wanted to mention one thing in case it appeals at all : you could use the Qt API internally here if it's easier or better. The reason we couldn't do that for FileIconColumn is that it would have meant passing Qt types through the CellData API, but that's not necessarily a problem here if we can distill an int or string from the Qt query.
Sorting by file extension is an approximation of sorting by file type, but is likely enough for our purposes. `std::filesystem::path::extension()` returns the last part of the filename from the rightmost `.`, which means "foo.tar.gz" will sort with "foo.gz", but this is preferable to a more greedy approach that would treat "foo.0001.exr" as having an extension of "0001.exr".
murraystevenson
force-pushed
the
fileIconSortValue
branch
from
ba57911
to
e0055bc
Compare
Thanks, definitely worth considering. We could potentially use QMimeDatabase for this, though sorting by MIME type may be less useful than sorting by extension: @ericmehl any Windows concerns that we should address before merging? The latest push is just a rebase to resolve the |
I think we should be fine on this PR. Sorting non-English characters on Windows will work out the same as on Linux (once #6006 is solved and merged) since we'll be converting to UTF-8 (same as Linux uses throughout) in So LGTM from that perspective. |
This makes the FileIconPathColumn sortable via the
CellData::sortValueproperty. This sorts by file extension, which is an approximation of sorting by file type, but is likely enough for our purposes.@ericmehl In light of #6006, do you think we will need similar special handling here for non-english characters on Windows?